Skip to content

Ensure plugin passes all Plugin Check categories #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ironprogrammer wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Ensure plugin passes all Plugin Check categories #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
758e4fa
Escape output
ironprogrammer Oct 11, 2024
36aa9f0
Ignore escaping hard-coded string
ironprogrammer Oct 11, 2024
fec872e
Use preferred wp_rand
ironprogrammer Oct 8, 2024
d9bbfce
Add GPLv2 license info
ironprogrammer Oct 24, 2024
f24ccfc
Bump tested up to version
ironprogrammer Oct 24, 2024
50600cb
Bump stable tag to match SVN
ironprogrammer Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions hello.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
<?php
/**
* @package Hello_Dolly
* @version 1.7.2
* @version 1.7.3
*/
/*
Plugin Name: Hello Dolly
Plugin URI: http://wordpress.org/plugins/hello-dolly/
Description: This is not just a plugin, it symbolizes the hope and enthusiasm of an entire generation summed up in two words sung most famously by Louis Armstrong: Hello, Dolly. When activated you will randomly see a lyric from <cite>Hello, Dolly</cite> in the upper right of your admin screen on every page.
Author: Matt Mullenweg
Version: 1.7.2
Version: 1.7.3
Author URI: http://ma.tt/
License: GPLv2 or later
License URI: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
*/

function hello_dolly_get_lyric() {
Expand Down Expand Up @@ -46,7 +48,7 @@ function hello_dolly_get_lyric() {
$lyrics = explode( "\n", $lyrics );

// And then randomly choose a line.
return wptexturize( $lyrics[ mt_rand( 0, count( $lyrics ) - 1 ) ] );
return wptexturize( $lyrics[ wp_rand( 0, count( $lyrics ) - 1 ) ] );
}

// This just echoes the chosen line, we'll position it later.
Expand All @@ -59,9 +61,9 @@ function hello_dolly() {

printf(
'<p id="dolly"><span class="screen-reader-text">%s </span><span dir="ltr"%s>%s</span></p>',
__( 'Quote from Hello Dolly song, by Jerry Herman:', 'hello-dolly' ),
$lang,
$chosen
esc_html__( 'Quote from Hello Dolly song, by Jerry Herman:', 'hello-dolly' ),
$lang, // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
esc_html( $chosen )
);
}

Expand Down
6 changes: 4 additions & 2 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
=== Hello Dolly ===
Contributors: matt, wordpressdotorg
Stable tag: 1.7.2
Tested up to: 6.1
Stable tag: 1.7.3
Tested up to: 6.6
Requires at least: 4.6
License: GPLv2 or later
License URI: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html

This is not just a plugin, it symbolizes the hope and enthusiasm of an entire generation summed up in two words sung most famously by Louis Armstrong.

Expand Down