Icon block: Add CSS to preserve stroke-scaling#79116
Open
jasmussen wants to merge 1 commit into
Open
Conversation
jasmussen
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +395 B (0%) Total Size: 8.59 MB 📦 View Changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Related to #78808 (comment)
This PR explicitly sets the stroke-scaling effect of icons in the Icon block to be default, that strokes are maintained.
There is no visual effect of applying this at the moment, but it adds a safeguard so that if/when #78808 lands, icons in the icon block retain their same visual effect. Without this, icons could look like this:
With this CSS in place, they would instead look like this
Why?
Converting the icon library to be stroke-based would still be beneficial for the icon block. We could add a togglecontrol on whether to maintain the stroke-width or not, and even a slider to define the thickness of the stroke.
But for now, it would keep the visuals identical.
Testing Instructions
Test the icon block with icons at various sizes. There should be no visual changes.