Backport to 23.3: 10 cherry-picks for stable#78848
Closed
arthur791004 wants to merge 10 commits into
Closed
Conversation
* Hide image dimension tools when a state is selected * Hide block supports aspect ratio ---- Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
…78757) Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
…oter (#78708) * Media Editor Modal: Try out placing the save and cancel buttons in the footer * Update tsconfig * Reorganise things a little better * Try breaking the controls up into separate groups to allow three different breakpoint arrangements * Add wrap if it's really needed Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
* e2e-test-utils-playwright: add src to published NPM files * Cleanup tsconfig and stop building code
arthur791004
requested review from
ajitbohra,
ellatrix,
fabiankaegy and
kevin940726
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
Bot
added
[Package] Editor
arthur791004
added
the
[Type] Build Tooling
|
Size Change: +482 B (+0.01%) Total Size: 8.18 MB 📦 View Changed
ℹ️ View Unchanged
|
Core's re-introduced client-side media processing (changeset 62428) restored a pre-#75793 REST API root index that still exposes the file-less `image_output_formats`, `jpeg_interlaced`, `png_interlaced`, and `gif_interlaced` settings. When the plugin runs against Core trunk, these keys are present, so the `assertArrayNotHasKey` assertions in the media processing test fail. The proper fix lives in Core, where wordpress-develop#12007 removes these redundant index keys in favor of the per-attachment `image_output_format` and `image_save_progressive` response fields. Until that PR merges, disable the affected assertions and link to it so they can be reactivated. See WordPress/wordpress-develop#12007
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
arthur791004
changed the title
Contributor
|
Closing this PR, as we runned the script to cherry pick manually. |
Contributor
|
Thanks for handling this, folks! |
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Cherry-picks 10 PRs onto
release/23.3for the upcoming 23.3 stable:Backport to Gutenberg RC(genuine release fixes).Why?
Direct push to
release/*is restricted to the Gutenberg Core team — opening this PR so a Core team member can merge it.PRs included
Backport-labeled (release fixes):
CI / data freshness picks (needed for green CI on this branch):
Media_Processing_Test::test_get_rest_index_should_return_additional_settings_can_upload_filesfails on Core trunk without this)caniuse-lite is 6 months oldwarning whichjest-consoleturns into a JS test failure)All 10 are assigned to the Gutenberg 23.3 milestone so they appear in the stable changelog regen.
Follow-ups after merge
The standard
npm run other:cherry-pickscript normally comments on each source PR and removes theBackport to Gutenberg RClabel. That will need to be done manually here for the 8 backport-labeled PRs (or by re-running the script post-merge to clean up labels).