Skip to content

Fix type of $block_instance parameter in block_core_image_render_lightbox()#78790

Merged
westonruter merged 2 commits into
trunkfrom
fix/docs-for-block-core-image-render-lightbox
May 29, 2026
Merged

Fix type of $block_instance parameter in block_core_image_render_lightbox()#78790
westonruter merged 2 commits into
trunkfrom
fix/docs-for-block-core-image-render-lightbox

Conversation

@westonruter

Copy link
Copy Markdown
Member

This is a follow-up to #62906, and specifically to 1077e73. When the $block_instance parameter was added to the block_core_image_render_lightbox() function, it was incorrectly typed as an array when it is actually a WP_Block.

@westonruter westonruter requested a review from t-hamano May 28, 2026 23:41
@westonruter westonruter added [Package] Block library /packages/block-library [Block] Gallery Affects the Gallery Block - used to display groups of images labels May 28, 2026
@github-actions

This comment was marked as outdated.

1 similar comment
@github-actions

This comment was marked as outdated.

@westonruter westonruter changed the title Fix type of $block_instance parameter in block_core_image_render_lightbox() Fix type of $block_instance parameter in block_core_image_render_lightbox() May 28, 2026
@westonruter westonruter added the [Type] Bug An existing feature does not function as intended label May 28, 2026
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter merged commit 08c646c into trunk May 29, 2026
77 of 86 checks passed
@westonruter westonruter deleted the fix/docs-for-block-core-image-render-lightbox branch May 29, 2026 03:05
@github-actions github-actions Bot added this to the Gutenberg 23.4 milestone May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Gallery Affects the Gallery Block - used to display groups of images [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants