Add a grid variation to the Columns block#78716
Closed
tellthemachines wants to merge 1 commit into
Closed
Conversation
tellthemachines
added
[Type] Enhancement
|
Size Change: +331 B (0%) Total Size: 8.18 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
Author
|
Closing this as #78713 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #70355; alternative to #78713.
Tries adding a block variation to Columns which switches it to a grid layout with a column count of whatever number of columns the Columns block has set.
With the recently added support for responsive layout styles (see #78543), this will allow fine-tuning the responsive behaviour of the Columns block.
When Columns is set to grid, its "columns" and "stack on mobile" settings are hidden, and it's possible to configure its grid layout. The "width" setting in its child Column blocks is also hidden, but it becomes possible to set grid spans on them.
WIP - written with codex/gpt 5.5. I haven't properly human-reviewed it yet!
Testing Instructions
Note that when switching between variations, similarly to what happens with Group variations, all layout-specific settings are lost. This means that stuff like custom Column widths will disappear too. Make use of the undo button as needed 😅
Screenshots or screencast
lol I just realised we're exposing an empty layout panel when no controls are available:
might fix that separately as it's a bug that can appear in other contexts.
Use of AI Tools