Skip to content

Fix: Guard require_once calls in generated PHP files against deployment race conditions #78110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikachan merged 2 commits into from
May 11, 2026
Merged

Fix: Guard require_once calls in generated PHP files against deployment race conditions #78110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e0b87d
Fix fatal errors from missing files during deploys
mikachan May 8, 2026
b3ff68d
Build single array of page files
mikachan May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/wp-build/lib/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1241,11 +1241,19 @@ async function generatePagesPhp( pageData, replacements ) {
await Promise.all( pageGenerationPromises );

// Generate pages.php loader
const pageIncludes = pageData
.map( ( page ) => {
return `require_once __DIR__ . '/pages/${ page.slug }/page.php';\nrequire_once __DIR__ . '/pages/${ page.slug }/page-wp-admin.php';`;
} )
.join( '\n' );
const pageFiles = pageData.flatMap( ( page ) => [
`\t__DIR__ . '/pages/${ page.slug }/page.php'`,
`\t__DIR__ . '/pages/${ page.slug }/page-wp-admin.php'`,
] );
const pageIncludes = [
'foreach ( [',
pageFiles.join( ',\n' ) + ',',
'] as $file ) {',
'\tif ( file_exists( $file ) ) {',
'\t\trequire_once $file;',
'\t}',
'}',
].join( '\n' );

await generatePhpFromTemplate(
'pages.php.template',
Expand Down
6 changes: 5 additions & 1 deletion packages/wp-build/templates/module-registration.php.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ function {{PREFIX}}_register_script_modules() {
$already_registered = true;

// Load build constants
$build_constants = require __DIR__ . '/constants.php';
$constants_file = __DIR__ . '/constants.php';
if ( ! file_exists( $constants_file ) ) {
return;
}
$build_constants = require $constants_file;
$modules_dir = __DIR__ . '/modules';
$modules_file = $modules_dir . '/registry.php';

Expand Down
Loading