Migrate native tests to workspace by USERSATOSHI · Pull Request #77425 · WordPress/gutenberg

USERSATOSHI · 2026-04-16T13:08:32Z

What?

Why?

The issue provides more context, but in short, this PR ensures the workspace package does not rely on root dependencies once dependency isolation is enforced.

How?

This PR converts tests/native into a new workspace @wordpress/native-tests while still relating the functionality.

Testing Instructions

run npm run test:native:*

github-actions · 2026-04-17T08:30:46Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: USERSATOSHI <tusharbharti@git.wordpress.org>
Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

USERSATOSHI · 2026-04-22T12:37:32Z

the argument forwarding has been resolved in this.

The logs ( generated a bash script to test arg forwarding )

--------------------------------------
1. test:native -- --testPathPattern
 Expected: jest receives --testPathPattern=<pattern>
--------------------------------------
> gutenberg@23.0.0-rc.1 test:native
> npm run --workspace @wordpress/native-tests test:native -- --testPathPattern=packages/react-native-editor --passWithNoTests
> @wordpress/native-tests@0.0.0 test:native
> cross-env NODE_ENV=test jest --config jest.config.js --testPathPattern=packages/react-native-editor --passWithNoTests


--------------------------------------
2. test:native -- --testNamePattern
 Expected: jest receives --testNamePattern=<pattern>
--------------------------------------
> gutenberg@23.0.0-rc.1 test:native
> npm run --workspace @wordpress/native-tests test:native -- --testNamePattern=should render --passWithNoTests
> @wordpress/native-tests@0.0.0 test:native
> cross-env NODE_ENV=test jest --config jest.config.js --testNamePattern=should render --passWithNoTests


--------------------------------------
3. test:native -- --verbose
 Expected: jest receives --verbose
--------------------------------------
> gutenberg@23.0.0-rc.1 test:native
> npm run --workspace @wordpress/native-tests test:native -- --verbose --passWithNoTests
> @wordpress/native-tests@0.0.0 test:native
> cross-env NODE_ENV=test jest --config jest.config.js --verbose --passWithNoTests


--------------------------------------
4. test:native -- --runInBand
 Expected: jest receives --runInBand
--------------------------------------
> gutenberg@23.0.0-rc.1 test:native
> npm run --workspace @wordpress/native-tests test:native -- --runInBand --passWithNoTests
> @wordpress/native-tests@0.0.0 test:native
> cross-env NODE_ENV=test jest --config jest.config.js --runInBand --passWithNoTests


--------------------------------------
5. test:native:update -- --testPathPattern (critical: hardcoded + forwarded args)
 Expected: jest receives --updateSnapshot AND --testPathPattern
--------------------------------------
> gutenberg@23.0.0-rc.1 test:native:update
> npm run --workspace @wordpress/native-tests test:native:update -- --testPathPattern=packages/react-native-editor --passWithNoTests
> @wordpress/native-tests@0.0.0 test:native:update
> npm run test:native -- --updateSnapshot --testPathPattern=packages/react-native-editor --passWithNoTests
> @wordpress/native-tests@0.0.0 test:native
> cross-env NODE_ENV=test jest --config jest.config.js --updateSnapshot --testPathPattern=packages/react-native-editor --passWithNoTests


--------------------------------------
6. test:native:watch (skipped - interactive)
 Expected: jest receives --watch
--------------------------------------


--------------------------------------
7. test:native:clean
 Expected: jest --clearCache runs
--------------------------------------
> gutenberg@23.0.0-rc.1 test:native:clean
> npm run --workspace @wordpress/native-tests test:native:clean && rm -rf $TMPDIR/jest_*
> @wordpress/native-tests@0.0.0 test:native:clean
> jest --clearCache --config jest.config.js

the script

#!/usr/bin/env bash

# Test native arg forwarding cases.
# Only shows the expanded command npm resolves — suppresses actual test output.

BOLD="\033[1m"
RESET="\033[0m"

run_case() {
	local num="$1"
	local desc="$2"
	local expected="$3"
	shift 3

	echo ""
	echo "--------------------------------------"
	echo -e "${BOLD}${num}. ${desc}${RESET}"
	echo "   Expected: ${expected}"
	echo "--------------------------------------"
	# Run the command, only show lines npm prints before handing off to jest
	# (the "> script" and "> command" lines), suppress everything after
	"$@" 2>&1 | grep -E "^>" || true
	echo ""
}

echo ""
echo "======================================"
echo " Native Test Arg Forwarding Test Cases"
echo "======================================"

run_case 1 \
	"test:native -- --testPathPattern" \
	"jest receives --testPathPattern=<pattern>" \
	npm run test:native -- --testPathPattern='packages/react-native-editor' --passWithNoTests

run_case 2 \
	"test:native -- --testNamePattern" \
	"jest receives --testNamePattern=<pattern>" \
	npm run test:native -- --testNamePattern='should render' --passWithNoTests

run_case 3 \
	"test:native -- --verbose" \
	"jest receives --verbose" \
	npm run test:native -- --verbose --passWithNoTests

run_case 4 \
	"test:native -- --runInBand" \
	"jest receives --runInBand" \
	npm run test:native -- --runInBand --passWithNoTests

run_case 5 \
	"test:native:update -- --testPathPattern (critical: hardcoded + forwarded args)" \
	"jest receives --updateSnapshot AND --testPathPattern" \
	npm run test:native:update -- --testPathPattern='packages/react-native-editor' --passWithNoTests

run_case 6 \
	"test:native:watch (skipped - interactive)" \
	"jest receives --watch" \
	echo "   Skipped (interactive mode)"

run_case 7 \
	"test:native:clean" \
	"jest --clearCache runs" \
	npm run test:native:clean

echo "======================================"
echo " Done. Review expanded commands above."
echo "======================================"
echo ""

USERSATOSHI · 2026-04-30T13:59:54Z

Since the integration migration PR has been merged, we can review this one (in free time) and then close Phase 1.

cc: @manzoorwanijk

Copilot

Pull request overview

Migrates the native (React Native) Jest test suite into its own workspace package (@wordpress/native-tests) to reduce reliance on the monorepo root dependencies and align with the broader “tests/tools as workspaces” initiative.

Changes:

Added test/native/package.json to define the new @wordpress/native-tests workspace and its test scripts/dependencies.
Updated test/native/jest.config.js to resolve globs relative to the repo root and include tsx in the package index glob.
Updated root package.json / package-lock.json to register the new workspace and route test:native:* scripts through it (and remove root-level reassure).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
test/native/package.json	Introduces the `@wordpress/native-tests` workspace package with native test scripts and dependencies.
test/native/jest.config.js	Adjusts path/glob resolution to behave correctly when run from a workspace context.
package.json	Adds `test/native` to workspaces and updates `test:native:*` scripts to use `--workspace @wordpress/native-tests`.
package-lock.json	Reflects the new workspace and dependency moves (including removing root `reassure`).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

manzoorwanijk · 2026-05-02T14:18:19Z

Linting is currently broken in trunk. We will need another trunk merge after #77888 is shipped.

manzoorwanijk

Apart from the inline comments/suggestions, let us add a minimal readme for the workspace.

manzoorwanijk · 2026-05-03T11:08:26Z

 		"react-dom": "18.3.1",
 		"react-scanner": "1.2.0",
-		"reassure": "0.7.1",
+		"resize-observer-polyfill": "1.5.1",


Why do we need resize-observer-polyfill in the root? I think we can remove it.

manzoorwanijk · 2026-05-03T11:12:58Z

+		"test:native": "cross-env NODE_ENV=test jest --config jest.config.js",
+		"test:native:watch": "npm run test:native -- --watch",
+		"test:native:clean": "jest --clearCache --config jest.config.js",
+		"test:native:debug": "cross-env NODE_ENV=test jest --runInBand --verbose --config jest.config.js",


test:native:debug no longer attaches a debugger

Trunk:

"test:native:debug": "cross-env NODE_ENV=test node --inspect-brk node_modules/.bin/jest --runInBand --verbose --config test/native/jest.config.js"

This PR

"test:native:debug": "cross-env NODE_ENV=test jest --runInBand --verbose --config jest.config.js"

Both node --inspect-brk and the explicit node_modules/.bin/jest are gone. Without --inspect-brk the V8 inspector is never started and there is nothing to attach a debugger to — the :debug variant is now identical in behavior to a plain verbose run.

manzoorwanijk · 2026-05-03T11:14:37Z

+		"@testing-library/react-native": "^12.0.0",
+		"babel-jest": "^29.7.0",
+		"cross-env": "^7.0.3",
+		"glob": "^10.3.10",


The rest of the repo uses "glob": "7.1.2", let us the same version with a version range

Suggested change

"glob": "^10.3.10",

"glob": "^7.1.2",

manzoorwanijk · 2026-05-03T11:15:31Z

+		"gutenberg",
+		"native-tests"
+	],
+	"homepage": "https://github.com/WordPress/gutenberg/tree/HEAD/test/native/README.md",


This readme does not exist. Let us create it but point the homepage simply to the directory.

Suggested change

"homepage": "https://github.com/WordPress/gutenberg/tree/HEAD/test/native/README.md",

"homepage": "https://github.com/WordPress/gutenberg/tree/HEAD/test/native",

manzoorwanijk · 2026-05-03T11:18:39Z

+	"bugs": {
+		"url": "https://github.com/WordPress/gutenberg/issues"
+	},
+	"devDependencies": {


There still are many dependencies which are imported in the workspace but not imported. Let us ensure to declare all of the dependencies which are imported.

I asked Claude to scan for them and here is the list

Imported but NOT declared on the workspace

Dep Where used Currently resolves via

@wordpress/api-fetch helpers hoist from packages/react-native-editor

@wordpress/block-editor helpers, tests hoist (workspace package)

@wordpress/block-library helpers, tests hoist (workspace package)

@wordpress/blocks tests hoist (workspace package)

@wordpress/core-data helpers hoist (workspace package)

@wordpress/data helpers, tests hoist (workspace package)

@wordpress/edit-post helpers hoist from packages/react-native-editor

@wordpress/element helpers, tests hoist (workspace package)

@wordpress/react-native-bridge helpers, mocks hoist from packages/react-native-editor

react helper hoist from root

react-native setup, mocks hoist from packages/react-native-editor

react-native-gesture-handler setup.js hoist from packages/react-native-editor

react-native-reanimated setup.js + helpers hoist from packages/react-native-editor

react-native-safe-area-context setup.js hoist from packages/react-native-editor

uuid helpers hoist (multiple packages declare it)

jest-matcher-utils matchers/ hoist from packages/jest-console

…polyfill

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+	"devDependencies": {
+		"@emotion/jest": "^11.14.2",
+		"@testing-library/react-native": "^12.0.0",
+		"@wordpress/api-fetch": "file:../../packages/api-fetch",
+		"@wordpress/block-editor": "file:../../packages/block-editor",
+		"@wordpress/block-library": "file:../../packages/block-library",
+		"@wordpress/blocks": "file:../../packages/blocks",
+		"@wordpress/core-data": "file:../../packages/core-data",
+		"@wordpress/data": "file:../../packages/data",
+		"@wordpress/edit-post": "file:../../packages/edit-post",
+		"@wordpress/element": "file:../../packages/element",
+		"@wordpress/react-native-bridge": "file:../../packages/react-native-bridge",
+		"babel-jest": "^29.7.0",
+		"cross-env": "^7.0.3",
+		"glob": "^7.1.2",
+		"jest": "^29.6.2",
+		"jest-junit": "^13.0.0",
+		"jest-matcher-utils": "^29.6.2",
+		"jest-watch-typeahead": "^2.2.2",
+		"react": "18.3.1",
+		"react-native": "0.73.3",
+		"react-native-gesture-handler": "2.14.1",
+		"react-native-reanimated": "3.6.2",
+		"react-native-safe-area-context": "4.8.2",
+		"reassure": "^0.7.1",
+		"uuid": "11.1.1"


…resets

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+	"devDependencies": {
+		"@babel/plugin-transform-async-generator-functions": "^7.25.7",
+		"@babel/plugin-transform-dynamic-import": "^7.25.7",
+		"@babel/plugin-transform-export-namespace-from": "^7.25.7",
+		"@babel/plugin-transform-react-jsx": "^7.25.7",
+		"@babel/plugin-transform-react-jsx-source": "^7.27.1",
+		"@babel/plugin-transform-runtime": "^7.25.7",
+		"@emotion/jest": "^11.14.2",
+		"@react-native/babel-preset": "0.73.10",
+		"@testing-library/react-native": "^12.0.0",
+		"@wordpress/api-fetch": "file:../../packages/api-fetch",
+		"@wordpress/block-editor": "file:../../packages/block-editor",
+		"@wordpress/block-library": "file:../../packages/block-library",
+		"@wordpress/blocks": "file:../../packages/blocks",
+		"@wordpress/core-data": "file:../../packages/core-data",
+		"@wordpress/data": "file:../../packages/data",
+		"@wordpress/edit-post": "file:../../packages/edit-post",
+		"@wordpress/element": "file:../../packages/element",
+		"@wordpress/react-native-bridge": "file:../../packages/react-native-bridge",
+		"babel-jest": "^29.7.0",
+		"babel-plugin-react-native-platform-specific-extensions": "1.1.1",
+		"cross-env": "^7.0.3",
+		"glob": "^7.1.2",
+		"jest": "^29.6.2",
+		"jest-junit": "^13.0.0",
+		"jest-matcher-utils": "^29.6.2",
+		"jest-watch-typeahead": "^2.2.2",
+		"react": "18.3.1",
+		"react-native": "0.73.3",
+		"react-native-gesture-handler": "2.14.1",
+		"react-native-reanimated": "3.6.2",
+		"react-native-safe-area-context": "4.8.2",
+		"reassure": "^0.7.1",
+		"uuid": "11.1.1"


+		"test:native": "cross-env NODE_ENV=test jest --config jest.config.js",
+		"test:native:watch": "npm run test:native -- --watch",
+		"test:native:clean": "jest --clearCache --config jest.config.js",
+		"test:native:debug": "cross-env NODE_ENV=test node --inspect-brk node_modules/.bin/jest --runInBand --verbose --config jest.config.js",


manzoorwanijk · 2026-05-05T04:08:38Z

Let us address Copilot's last two comments - #77425 (review), then we are good to go.

manzoorwanijk

Thank you for the changes. This looks great now.

manzoorwanijk · 2026-05-05T13:48:45Z

+		"react-native-safe-area-context": "4.8.2",
+		"react-native-svg": "14.0.0",
+		"reassure": "^0.7.1",
+		"uuid": "11.1.1"


After #77960, we won't need uuid here. Let us get rid of it.

got it removing it

USERSATOSHI added 2 commits April 16, 2026 18:24

chore: migrate native tests to workspace

70d07cd

chore: add publishConfig to package.json for public access

5ce5594

USERSATOSHI marked this pull request as ready for review April 17, 2026 08:30

USERSATOSHI added 2 commits April 22, 2026 13:41

tests: append double-dash to support original arg forwarding

cb4dcc7

Merge branch 'trunk' into try/migrate-test-native-to-workspace

e408f4e

USERSATOSHI added 2 commits April 28, 2026 20:00

Merge branch trunk into try/migrate-test-native-to-workspace

2e450cd

Merge branch 'trunk' into try/migrate-test-native-to-workspace

73560db

manzoorwanijk self-requested a review April 30, 2026 14:54

manzoorwanijk self-assigned this Apr 30, 2026

manzoorwanijk requested a review from Copilot April 30, 2026 14:54

manzoorwanijk added the [Type] Code Quality Issues or PRs that relate to code quality label Apr 30, 2026

Copilot started reviewing on behalf of manzoorwanijk April 30, 2026 14:55 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread test/native/package.json

Comment thread test/native/package.json Outdated

manzoorwanijk mentioned this pull request Apr 30, 2026

Idea: Clean up root package.json and convert tools and tests to workspace packages #75041

Open

38 tasks

chore: add glob dependency and simplify debug script

a46958f

manzoorwanijk reviewed May 1, 2026

View reviewed changes

Comment thread test/native/package.json Outdated

USERSATOSHI added 2 commits May 2, 2026 19:24

Merge branch 'trunk' into try/migrate-test-native-to-workspace

6c55e10

chore: update lock file

507c180

Merge branch 'trunk' into try/migrate-test-native-to-workspace

adac5db

manzoorwanijk requested changes May 3, 2026

View reviewed changes

USERSATOSHI added 2 commits May 4, 2026 15:28

chore: update package dependencies and remove unused resize-observer-…

a3a135a

…polyfill

chore: reorder jest-matcher-utils dependency in package.json

d88b39f

manzoorwanijk requested a review from Copilot May 4, 2026 10:05

Copilot started reviewing on behalf of manzoorwanijk May 4, 2026 10:05 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

chore: update devDependencies in package.json for Babel plugins and p…

817b8c9

…resets

USERSATOSHI added 2 commits May 4, 2026 17:46

chore: reorder devdependency in package.json

e73d443

chore: reorder devdependency in package.json

681fb00

manzoorwanijk requested a review from Copilot May 5, 2026 03:54

Copilot started reviewing on behalf of manzoorwanijk May 5, 2026 03:55 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Merge branch 'trunk' into try/migrate-test-native-to-workspace

b353c41

github-actions Bot mentioned this pull request May 5, 2026

Add a scheduled Gutenberg upstream TypeScript watch and triage workflow imjlk/wp-typia#283

Closed

USERSATOSHI added 2 commits May 5, 2026 17:28

chore: added missing deps

e22f834

Merge branch 'trunk' into try/migrate-test-native-to-workspace

435cf69

manzoorwanijk approved these changes May 5, 2026

View reviewed changes

USERSATOSHI added 3 commits May 5, 2026 18:35

chore: update package-lock.json

9da133a

Merge branch 'trunk' into try/migrate-test-native-to-workspace

96ada2e

chore: update package-lock.json

7620c31

manzoorwanijk reviewed May 5, 2026

View reviewed changes

chore: remove uuid

39ffdeb

manzoorwanijk enabled auto-merge (squash) May 5, 2026 14:48

manzoorwanijk merged commit 6c1c2fc into WordPress:trunk May 5, 2026
38 checks passed

github-actions Bot added this to the Gutenberg 23.2 milestone May 5, 2026

	"homepage": "https://github.com/WordPress/gutenberg/tree/HEAD/test/native/README.md",
	"homepage": "https://github.com/WordPress/gutenberg/tree/HEAD/test/native",

Dep	Where used	Currently resolves via
`@wordpress/api-fetch`	helpers	hoist from `packages/react-native-editor`
`@wordpress/block-editor`	helpers, tests	hoist (workspace package)
`@wordpress/block-library`	helpers, tests	hoist (workspace package)
`@wordpress/blocks`	tests	hoist (workspace package)
`@wordpress/core-data`	helpers	hoist (workspace package)
`@wordpress/data`	helpers, tests	hoist (workspace package)
`@wordpress/edit-post`	helpers	hoist from `packages/react-native-editor`
`@wordpress/element`	helpers, tests	hoist (workspace package)
`@wordpress/react-native-bridge`	helpers, mocks	hoist from `packages/react-native-editor`
`react`	helper	hoist from root
`react-native`	setup, mocks	hoist from `packages/react-native-editor`
`react-native-gesture-handler`	setup.js	hoist from `packages/react-native-editor`
`react-native-reanimated`	setup.js + helpers	hoist from `packages/react-native-editor`
`react-native-safe-area-context`	setup.js	hoist from `packages/react-native-editor`
`uuid`	helpers	hoist (multiple packages declare it)
`jest-matcher-utils`	matchers/	hoist from `packages/jest-console`

Conversation

USERSATOSHI commented Apr 16, 2026

What?

Why?

How?

Testing Instructions

Uh oh!

github-actions Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

USERSATOSHI commented Apr 22, 2026

Uh oh!

USERSATOSHI commented Apr 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manzoorwanijk commented May 2, 2026

Uh oh!

manzoorwanijk left a comment

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk May 3, 2026

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk May 3, 2026

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk May 3, 2026

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk May 3, 2026

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Imported but NOT declared on the workspace

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

manzoorwanijk commented May 5, 2026

Uh oh!

manzoorwanijk left a comment

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk May 5, 2026

Choose a reason for hiding this comment

Uh oh!

USERSATOSHI May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Apr 17, 2026 •

edited

Loading

manzoorwanijk May 3, 2026 •

edited

Loading