-
Notifications
You must be signed in to change notification settings - Fork 4.8k
CollapsibleCard: add animations
#76378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8489821
Animate chevron rotation on CollapsibleCard toggle
ciampo 50a6ea4
Add fade + translate animation to CollapsibleCard content
ciampo 3758b07
Refine content animation: open-only with delay, no exit animation
ciampo 848a1ea
Animate whole card height
ciampo 726c50b
CHANGELOG
ciampo 80164c7
use correct CSS layer
ciampo 0de2140
Add stacked storybook example
ciampo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,32 @@ | ||
| import { forwardRef } from '@wordpress/element'; | ||
| import clsx from 'clsx'; | ||
| import * as Card from '../card'; | ||
| import * as Collapsible from '../collapsible'; | ||
| import styles from './style.module.css'; | ||
| import type { ContentProps } from './types'; | ||
|
|
||
| /** | ||
| * The collapsible content area of the card. Hidden when collapsed, | ||
| * visible when expanded. | ||
| */ | ||
| export const Content = forwardRef< HTMLDivElement, ContentProps >( | ||
| function CollapsibleCardContent( { render, ...restProps }, ref ) { | ||
| function CollapsibleCardContent( | ||
| { className, render, children, ...restProps }, | ||
| ref | ||
| ) { | ||
| return ( | ||
| <Collapsible.Panel | ||
| ref={ ref } | ||
| render={ <Card.Content render={ render } /> } | ||
| className={ clsx( styles.content, className ) } | ||
| { ...restProps } | ||
| /> | ||
| > | ||
| <Card.Content | ||
| className={ styles[ 'content-inner' ] } | ||
| render={ render } | ||
| > | ||
| { children } | ||
| </Card.Content> | ||
| </Collapsible.Panel> | ||
| ); | ||
| } | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to DOM structure and styles actually now make adding
hiddenUntilFoundtrivial (cc @mirka who suggested it in #76280 (review) )There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#76498