Tests: Add unit tests for Button block __experimentalLabel functionality (follows #74163)#74175
Closed
SirLouen wants to merge 1 commit into
Closed
Tests: Add unit tests for Button block __experimentalLabel functionality (follows #74163)#74175SirLouen wants to merge 1 commit into
SirLouen wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SirLouen
added
the
[Type] Automated Testing
SirLouen
requested review from
jasmussen
and removed request for
ajitbohra and
fabiankaegy
SirLouen
force-pushed
the
tests/74163
branch
from
a22ec1e to
669471f
Compare
youknowriad
reviewed
Dec 23, 2025
|
|
||
| it( 'returns "Button" when attributes is undefined', () => { | ||
| expect( getLabel( undefined ) ).toBe( 'Button' ); | ||
| } ); |
Contributor
There was a problem hiding this comment.
Like discussed in the other PR, and given all the other blocks don't do defensive coding for undefined and null, I think we should remove these two test cases and ship this PR.
youknowriad
force-pushed
the
update/button-block-label
branch
from
8281e8e to
146ae80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adding some Unit Tests for #74163