Fix bindableAttributes only being returned for the selected block#74061
Merged
Conversation
talldan
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -38 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
Member
|
I’m also concerned about perf regression. Let’s ping more folks working on block bindings. |
|
Flaky tests detected in 6f2a04d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20294214680
|
Contributor
Author
|
Oh yep, I was going to check the perf results before adding more reviewers, but appreciate you adding them anyway. If this doesn't look good, another option would be to move bindings related context to a new provider that's separate to PrivateBlockContext, but let's see how it goes. |
Contributor
Author
|
The results look ok: The topToolbar test doesn't look great, but hard to say if it's a real issue. I can re-run a few times to see how it looks. |
Contributor
Author
|
Results from second run: I'll run one more time. |
cbravobernal
approved these changes
Dec 17, 2025
cbravobernal
left a comment
cbravobernal
left a comment
Contributor
There was a problem hiding this comment.
Codewise. LGTM. Let's see the performance results.
Contributor
Author
|
Third run of the perf tests: I think it looks ok, so I'll merge the PR, and will check codevitals results when I'm back online tomorrow. Thanks folks for helping me avoid a regression 😊 |
Member
|
Thanks for the quick follow-up, @talldan! I agree, the CodeVitals site is better for tracking similar regressions. |
Contributor
Author
|
Not seeing any issues this morning 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes a logic error mentioned here - #74029 (comment).
After that code change
bindableAttributeswould have only been return for the selected block due to the early return in theuseSelectbody.Why?
It looks like
bindingPlaceholderandbindingLabelneed thebindableAttributesfor unselected blocks.How?
Moves it to a different useSelect. The concern is that it may regress previous performance improvements mentioned here:
#74029 (comment)
Lets find out.
Testing Instructions
I'm not sure how to test this, logically it should fix the issue.