Global Styles: Remove orphaned get_svg_filters() method#74059
Conversation
Removes the unused get_svg_filters() method from WP_Theme_JSON_Gutenberg that was left behind after PR #49103 moved duotone functionality to WP_Duotone_Gutenberg. The method has no callers in the codebase and calls a non-existent function (wp_get_duotone_filter_svg). Its functionality has been fully replaced by WP_Duotone_Gutenberg::get_svg_definitions(). Closes #49213 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in c146764. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20291666673
|
|
This class is synced with the core. Unfortunately, we can't remove public methods because it would break backward compatibility. It's probably better to deprecate it and noop it. I'm sure there will be examples in the core for similar cases. |
|
Sweet. I'll poke around and see if I can make that happen. Closing this out for now. |
Summary
Removes the unused
get_svg_filters()method fromWP_Theme_JSON_Gutenbergthat was left behind after PR #49103 moved duotone functionality toWP_Duotone_Gutenberg.What Changed
get_svg_filters()method (34 lines) fromlib/class-wp-theme-json-gutenberg.phpWhy
After PR #49103 consolidated duotone generation logic in
WP_Duotone_Gutenberg, this method became orphaned:wp_get_duotone_filter_svg)WP_Duotone_Gutenberg::get_svg_definitions()Testing
Closes #49213
🤖 Generated with Claude Code