Switch from selector to useBlockEditingMode for AllowedBlocksControl#72728
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
requested review from
Mamaduka and
t-hamano
and removed request for
tellthemachines
jeryj
commented
Oct 27, 2025
Comment on lines
+15
to
+16
| const blockEditingMode = useBlockEditingMode(); | ||
| const isContentOnly = blockEditingMode === 'contentOnly'; |
Contributor
Author
There was a problem hiding this comment.
@Mamaduka - I believe you mentioned somewhere that useBlockEditingMode is faster than adding getBlockEditingMode. Trying to make it stick in my brain and make sure I got it right :)
Member
There was a problem hiding this comment.
Right. It should be preferred over custom useSelect. The useBlockEditingMode uses block context when possible and avoids creating a store subscription.
Member
There was a problem hiding this comment.
With how many total subscriptions we maintain in runtime, I imagine the actual performance impact is hard to pinpoint? I was mostly curious how we choose what to prioritize when spending time on performance.
Member
There was a problem hiding this comment.
In my experience, similar optimizations have a small impact and are hard to measure. These components are rendered only when the block is selected and don't create a subscription for every block on the canvas. But fixing similar paper cuts is a good thing.
I think fixes like #72496 are more impactful. The RichText can be rendered on canvas hundreds or thousands of times,
Personally, I do similar optimizations if it's a small change and doesn't complicate the logic. Otherwise, it's hard to justify complexity without real measurements.
Contributor
Author
There was a problem hiding this comment.
I share the same opinion as @Mamaduka. It's one of those bottle pickup things that is hard to measure in the moment, but is noticeable over time.
I've been looking at a lot of performance issues this week. As I happen across subscriptions that can be combined or easily prevented from running without adding complexity, I'm adding them to #72535 so I don't forget about them.
|
Size Change: -39 B (0%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 28, 2025
Mamaduka
left a comment
Mamaduka
left a comment
Member
There was a problem hiding this comment.
Works as expected. Couldn't spot any regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Minor perf - useBlockEditingMode is faster than a useSelect.
Why?
Perf
How?
instead of useSelect -> getBlockEditingMode, use useBlockEditingMode which gets the information from context (faster)
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast