Merge the global styles engine package into the existing style engine package#72559
Closed
andrewserong wants to merge 2 commits into
Closed
Merge the global styles engine package into the existing style engine package#72559andrewserong wants to merge 2 commits into
andrewserong wants to merge 2 commits into
Conversation
andrewserong
requested review from
aaronrobertshaw,
ramonjd,
talldan,
tellthemachines and
youknowriad
andrewserong
added
[Type] Code Quality
andrewserong
changed the title
|
Size Change: -4.11 kB (-0.19%) Total Size: 2.18 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7d62fac. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18706900406
|
Contributor
Author
|
We're not quite ready to make this API public as discussed in #72464 (comment), so I'll close this out for now. |
youknowriad
deleted the
merge/global-styles-engine-and-styles-engine-packages
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follows: #72464
Merge the contents of the
global-styles-enginepackage into the existingstyle-enginepackage, so that we export all these utility functions from the same canonical place for dealing with constructing styles from style objects.I'm very happy for any feedback / help on where to put things!
Why?
As discussed in #72464 (comment), to consolidate these utility functions and behaviours in the one place.
How?
I mostly used Claude Code to help me with this, and am putting this PR up at the end of my day, so apologies if there are any large errors or omissions!
global-styles-enginepackage tostyles-enginestylesfolder tostyle-definitionsindex.tsfile is a (relatively) clean set of exports, rather than including function definitions there directlyTesting Instructions
This is an unfortunately brief set of testing instructions for a large number of files changed, but:
I've only quickly spot-checked things for now, but will give it a more thorough test tomorrow.
As I mentioned earlier in this description, let me know if anyone has ideas for how everything could be structured / sit nicely alongside each other.