Skip to content

Pattern Overrides: Add support for Image caption attribute #72476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ockham merged 3 commits into from
Oct 22, 2025
Merged

Pattern Overrides: Add support for Image caption attribute #72476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ce86c2
Pattern Overrides: Add support for Image caption attribute
ockham Oct 20, 2025
a285492
Update overrides control message
ockham Oct 20, 2025
dc7851d
Remove check for caption attribute
ockham Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/patterns/src/components/pattern-overrides-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,12 @@ function PatternOverridesControls( {
}

const hasUnsupportedImageAttributes =
blockName === 'core/image' &&
( !! attributes.caption?.length || !! attributes.href?.length );
blockName === 'core/image' && !! attributes.href?.length;

const helpText =
! hasOverrides && hasUnsupportedImageAttributes
? __(
`Overrides currently don't support image captions or links. Remove the caption or link first before enabling overrides.`
`Overrides currently don't support image links. Remove the link first before enabling overrides.`
)
: __(
'Allow changes to this block throughout instances of this pattern.'
Expand Down
2 changes: 1 addition & 1 deletion packages/patterns/src/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const PARTIAL_SYNCING_SUPPORTED_BLOCKS = {
'core/paragraph': [ 'content' ],
'core/heading': [ 'content' ],
'core/button': [ 'text', 'url', 'linkTarget', 'rel' ],
'core/image': [ 'id', 'url', 'title', 'alt' ],
'core/image': [ 'id', 'url', 'title', 'alt', 'caption' ],
};

export const PATTERN_OVERRIDES_BINDING_SOURCE = 'core/pattern-overrides';
Loading