Terms Query: Remove some redundant attributes#72107
Merged
Merged
Conversation
ntsekouras
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
ntsekouras
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -156 B (-0.01%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Oct 6, 2025
cr0ybot
reviewed
Oct 6, 2025
|
Flaky tests detected in ac692c3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18287320565
|
Contributor
|
Personally, I support the direction of this PR. I know a lot of time has been spent developing this block, and I understand the desire to implement as many useful features as possible from the start. However, there is not much time until the 6.9 release. The more features we try to include in the initial release, the greater the chance that they will not make it into 6.9 and the greater the chance of bugs. In my opinion, the most important thing is to get it out of the experimental flag and be confident that it can be shipped in 6.9. To do that, we need to build something minimal and robust. We can repeat the iterations once it has stabilized. What do you think? |
Contributor
Author
I totally agree with this and regarding this, I'm not sure if bindings is the right approach for this block. |
cr0ybot
approved these changes
Oct 6, 2025
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: cr0ybot <cr0ybot@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I've been reviewing various PRs (including the original implementation) about this block and getting context for it and I think there is room for simplification.
It seems to me that this block borrowed a lot from Query block, but some things are not needed (at least not yet) and there is also the chance to make better decisions here by looking at our past approaches (I don't have something specific right now on my mind).
In this PR:
namespaceattribute. Is not used anywhere and in Query it was used as a way to have patterns for third party extenders' block variationspagesattribute.WP_Term_Querydoesn't support pagination likeWP_Querydoes and additionally we don't have any pagination for this block. We could probably implement it in the future manually if needed.include and exclude. It's not used anywheretermQueryId. Not used anywhere. In Query block is needed because we support pagination and we could have multiple Query blocks in the same page.TermsQueryContentextraneous wrapper.I'd appreciate reviews from folks already worked on this block and have way more context than me, in case I'm missing something.
Testing Instructions