[WIP] Block Support: Add anchor support for dynamic blocks#70995
Closed
t-hamano wants to merge 7 commits into
Closed
[WIP] Block Support: Add anchor support for dynamic blocks#70995t-hamano wants to merge 7 commits into
t-hamano wants to merge 7 commits into
Conversation
t-hamano
added
[Type] Enhancement
Contributor
Author
|
Since #70993 has been merged, I'd like to close this PR and submit a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR is based on #70993
Once #70993 is merged, the anchor attribute will always be saved as block comments, regardless of whether the block saves its HTML to the database.
This PR uses that attribute to inject the anchor attribute into HTML during dynamic rendering.
This enables anchor support for dynamic blocks.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast