Workflows: Try different SHA#70048
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
From what I can see, it looks like a request error is occurring here: gutenberg/bin/log-performance-results.js Lines 88 to 94 in bcc41b1 Normally, a successful HTTP request to the code health should get a response with a 200 status code: However, after updating the base commit, we are getting a 405 error, which means the request is not allowed for the resource: Is this issue related to #69126? Maybe adding the appropriate permissions to that job will solve it? |
I can see commits tracked in CodeVitals after this PR, but double-checking won't hurt. cc @johnbillion, @desrosj |
|
One more thing I was wondering, does this SHA need to be updated? gutenberg/.github/workflows/performance.yml Line 112 in bcc41b1 It appears that in the past, when the minimum required WordPress version has been bumped, this commit hash has been updated as well.
I noticed that #70023 didn't update this line 🤔 |
|
Great catch, @t-hamano! I did a search and replace, but it looks like I missed the spot. |
|
This worked. Thanks for catching the missing SHA replacement, @t-hamano! |
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>


What?
Related #70023.
Try different SHA for the performance tests workflow. The current choice might have been too recent, and I don't see new commits in https://www.codevitals.run/project/gutenberg.
How?
See https://developer.wordpress.org/block-editor/explanations/architecture/performance/#update-the-reference-commit.
Testing Instructions
These changes are hard to test without merging.