Skip to content

fix: incorrect condiional check in Gutenberg_Token_Map_6_7::read_small_token()#68410

Closed
justlevine wants to merge 1 commit into
WordPress:trunkfrom
justlevine:fix/conditional-typo-read_small_token
Closed

fix: incorrect condiional check in Gutenberg_Token_Map_6_7::read_small_token()#68410
justlevine wants to merge 1 commit into
WordPress:trunkfrom
justlevine:fix/conditional-typo-read_small_token

Conversation

@justlevine

Copy link
Copy Markdown
Contributor

What?

This PR fixes an issue in Gutenberg_Token_Map_6_7::read_small_token() where a misplaced ) results in a strtoupper( {... text check logic ... }, causing the conditional to incorrectly handle case-insensitive checks.

Why?

While this issue was surfaced by PHPStan (via #66693) it can be remediated independently as part of #66598

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before After

@github-actions

github-actions Bot commented Dec 30, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <justlevine@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added the [Type] Code Quality Issues or PRs that relate to code quality label Jan 27, 2025
@carolinan

Copy link
Copy Markdown
Contributor

@carolinan carolinan added Needs PHP backport Needs PHP backport to Core Needs Testing Needs further testing to be confirmed. labels Jan 27, 2025
@github-actions github-actions Bot added the Stale label Mar 1, 2025
@justlevine justlevine force-pushed the fix/conditional-typo-read_small_token branch from 1635e72 to 5cda84c Compare April 18, 2025 23:07
@github-actions github-actions Bot removed the Stale label Apr 19, 2025
@github-actions github-actions Bot added the Stale label May 20, 2025
@Mamaduka

Copy link
Copy Markdown
Member

Hi, @justlevine

Now that we have removed WP 6.7 compat from the plugin (#70023). This patch needs to be submitted to the core repo.

I'm going to close this PR. Thanks again, @justlevine!

@Mamaduka Mamaduka closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs PHP backport Needs PHP backport to Core Needs Testing Needs further testing to be confirmed. Stale [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants