fix: incorrect condiional check in Gutenberg_Token_Map_6_7::read_small_token()#68410
fix: incorrect condiional check in Gutenberg_Token_Map_6_7::read_small_token()#68410justlevine wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This line is also present in https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/class-wp-token-map.php#L610 |
1635e72 to
5cda84c
Compare
|
Hi, @justlevine Now that we have removed WP 6.7 compat from the plugin (#70023). This patch needs to be submitted to the core repo. I'm going to close this PR. Thanks again, @justlevine! |
What?
This PR fixes an issue in
Gutenberg_Token_Map_6_7::read_small_token()where a misplaced)results in astrtoupper( {... text check logic ... }, causing the conditional to incorrectly handle case-insensitive checks.Why?
While this issue was surfaced by PHPStan (via #66693) it can be remediated independently as part of #66598
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast