Skip to content

Refactor "Settings" panel of Next Post block to use ToolsPanel instead of PanelBody#67976

Closed
rinkalpagdar wants to merge 6 commits into
WordPress:trunkfrom
rinkalpagdar:refractor-next-post-link
Closed

Refactor "Settings" panel of Next Post block to use ToolsPanel instead of PanelBody#67976
rinkalpagdar wants to merge 6 commits into
WordPress:trunkfrom
rinkalpagdar:refractor-next-post-link

Conversation

@rinkalpagdar

Copy link
Copy Markdown
Contributor

Part of #67813
Fixes #67943

Testing Instructions

  • Add Next post block
  • Open the settings panel

Screenshots or screencast

|Before|After|
|before-next-post|after-next-post|

@github-actions

github-actions Bot commented Dec 13, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <rinkalpagdar@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Block] Post Navigation Link Affects the Post Navigation Link Block [Type] Enhancement A suggestion for improvement. labels Dec 13, 2024
Comment thread packages/block-library/src/post-navigation-link/edit.js Outdated
Comment thread packages/block-library/src/post-navigation-link/edit.js Outdated
@rinkalpagdar

Copy link
Copy Markdown
Contributor Author

Hello @fabiankaegy I have implemented your suggestion. Thanks for the feedback.

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've left some feedback so I'd be happy if you could check it out.

Comment thread packages/block-library/src/post-navigation-link/edit.js Outdated
Comment thread packages/block-library/src/post-navigation-link/edit.js
Comment thread packages/block-library/src/post-navigation-link/edit.js Outdated

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I just left a few more suggestions at the end, but overall it looks good.

However, we're running into an issue where the order of the controls doesn't match the order of the dropdown items:

display-order

This was reported in the comment, and will need to be resolved before I can ship this PR.

Sorry, but please be patient until that issue is resolved.

Comment thread packages/block-library/src/post-navigation-link/edit.js Outdated
Comment thread packages/block-library/src/post-navigation-link/edit.js Outdated
@rinkalpagdar

Copy link
Copy Markdown
Contributor Author

Thanks for the update! I just left a few more suggestions at the end, but overall it looks good.

However, we're running into an issue where the order of the controls doesn't match the order of the dropdown items:

display-order

This was reported in the comment, and will need to be resolved before I can ship this PR.

Sorry, but please be patient until that issue is resolved.

Hello @t-hamano
I have checked all properties of toolsPanelItem, Can you please guide me on how to maintain order of it?

@t-hamano

Copy link
Copy Markdown
Contributor

I have checked all properties of toolsPanelItem, Can you please guide me on how to maintain order of it?

As far as I know, there are currently no options to solve this.

I think we need to analyze the behavior of the ToolsPanel and ToolsPanelItem components itself and address it. See this discussion.

@t-hamano

Copy link
Copy Markdown
Contributor

Hi @rinkalpagdar, I noticed that this block was refactored by #70276 and has already been merged.

I'm sorry, I should have realized that multiple PRs had been submitted for the same block.

I would like to close this PR, but I appreciate your efforts 🙏

@t-hamano t-hamano closed this Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Post Navigation Link Affects the Post Navigation Link Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Next Post block to use ToolsPanel instead of PanelBody

3 participants