Add CSS classname to fix the negative margins not appearing in the Navigation Screen#67825
Merged
t-hamano merged 1 commit intoDec 11, 2024
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Hi @t-hamano, please check my PR when you have a moment. Thanks! |
jameskoster
approved these changes
Dec 11, 2024
jameskoster
left a comment
jameskoster
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this :)
t-hamano
approved these changes
Dec 11, 2024
t-hamano
left a comment
t-hamano
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the quick fix 👍
t-hamano
added
[Type] Regression
github-actions
Bot
removed
the
props-bot
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…tent (WordPress#67825) Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #67369
Related PR: #67575
Related comment: comment
What?
Due to regression introduced by #66851. The CSS classname
edit-site-sidebar-navigation-screen-mainwas removed from the<ItemGroup>, this caused negative margins not to be appliedWhy?
To apply negative margins.