Skip to content

Update global stylesheet docblocks with custom-css parameter.#67716

Merged
tellthemachines merged 3 commits into
trunkfrom
fix/docblocks-custom-css
Dec 9, 2024
Merged

Update global stylesheet docblocks with custom-css parameter.#67716
tellthemachines merged 3 commits into
trunkfrom
fix/docblocks-custom-css

Conversation

@tellthemachines

Copy link
Copy Markdown
Contributor

What?

#62357 made some updates to the global styles custom CSS handling logic, but neglected to update the docblocks for both gutenberg_get_global_stylesheet and WP_Theme_JSON_Gutenberg::get_stylesheet. This PR fixes the omission.

@tellthemachines tellthemachines marked this pull request as ready for review December 8, 2024 23:55
@tellthemachines tellthemachines self-assigned this Dec 8, 2024
@tellthemachines tellthemachines added the [Type] Bug An existing feature does not function as intended label Dec 8, 2024
@github-actions

github-actions Bot commented Dec 8, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown

Flaky tests detected in ee0734c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12226372102
📝 Reported issues:

@tellthemachines tellthemachines merged commit 24c0076 into trunk Dec 9, 2024
@tellthemachines tellthemachines deleted the fix/docblocks-custom-css branch December 9, 2024 02:42
@github-actions github-actions Bot added this to the Gutenberg 19.9 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants