WP Scripts: Make watch mode more resilient for developer errors#66752
Merged
Conversation
gziolo
added
[Type] Bug
gziolo
requested review from
ajitbohra,
nerrad,
ntwb and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
For reference, the previous contribution from @fabiankaegy which added improved support for |
gziolo
commented
Nov 5, 2024
|
Size Change: 0 B Total Size: 1.82 MB ℹ️ View Unchanged
|
sirreal
approved these changes
Nov 5, 2024
sirreal
left a comment
sirreal
left a comment
Member
There was a problem hiding this comment.
This looks good, thanks for these fixes 👍
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…Press#66752) * WP Scripts: Fix the watch mode so it continues working when errors pop up while developing * Improve the handling for parsing JSON files * Docs: Add changelog entry * Improve the warnings messages Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Extracted from #66466 (comment):
Why?
This was useful in the watch mode when running
wp-scripts startas it allowed developers made mistakes during development. There would be an error message displayed in the terminal that should help to resolve the issue without running the same command again.How?
Testing Instructions
I created a custom block from the Gutenberg repository and put it in the watch mode with:
npx wp-create-block example-block --no-wp-scripts cd example-block npx ../node_modules/.bin/wp-scripts startI made an error in
block.jsonfile to ensure it errors. I was able to see the warning coming from webpack config and the error coming from the bundler for the usage of import inside the JS code forblock.json. The command continued to work and resumed to fully operational after I fixed the JSON file and saved it again.Some examples after the changes applied with this PR while webpack continues to run in the watch mode: