Revert "Use npm workspaces for packages"#66270
Merged
Merged
Conversation
This reverts commit 4693c0f.
sirreal
requested review from
DAreRodz,
ObliviousHarmony,
adamsilverstein,
adamziel,
ajitbohra,
atimmer,
dmsnell,
draganescu,
ellatrix,
fabiankaegy,
gziolo,
juanmaguitar,
kevin940726,
luisherranz,
mmtr,
ndiego,
nerrad,
ntwb,
peterwilsoncc,
ryanwelcher,
swissspidy,
t-hamano and
talldan
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
2 similar comments
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
getdave
approved these changes
Oct 21, 2024
getdave
left a comment
getdave
left a comment
Contributor
There was a problem hiding this comment.
Thank you for wrangling this 🙇
Contributor
|
On confirmation from @sirreal I forced merged this as the CI would never pass due to nature of the PR. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
|
Can you reopen #59933? |
sirreal
added a commit
that referenced
this pull request
Oct 21, 2024
Member
Author
sirreal
added a commit
that referenced
this pull request
Oct 22, 2024
sirreal
added a commit
that referenced
this pull request
Oct 22, 2024
sirreal
added a commit
that referenced
this pull request
Oct 22, 2024
sirreal
added a commit
that referenced
this pull request
Oct 23, 2024
cbravobernal
added
the
[Type] Regression
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
) This reverts commit 4693c0f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revert to land this potentially disruptive change at a more convenient time.
Reverts #65681