Fix: Shadow/Font size preset panel crashes the editor#65765
Merged
Conversation
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +12 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Oct 1, 2024
Contributor
There was a problem hiding this comment.
Agreed. LGTM as an urgent fix. I'll see if I can create a slightly more sophisticated fix , still in app-land — it will help us to understand how to handle this better at the Navigator-level.
The E2E failure doesn't seem related, and can be encountered across many other PRs.
Contributor
Author
|
Thanks for the review! I think the E2E test failure is related to the core, so I would like to merge it once the core is fixed. Core ticket: https://core.trac.wordpress.org/ticket/60666 |
Contributor
|
Thank you! I've also created a PR with an alternative solution that could avoid the "flash of empty screen" while transitioning out #65790 |
Contributor
Author
|
Another critical error was found regarding font size presets: #65774 I believe that the issue is not related to #64777, but simply a problem with the font size preset logic itself, and it also occurs in WP 6.7. On the other hand, this PR does not need to be backported to WP6.7. Therefore, it might be better to merge this PR after backporting the fix for #65774 to WP 6.7. |
This was referenced Oct 1, 2024
ramonjd
reviewed
Oct 2, 2024
|
|
||
| const [ globalFluid ] = useGlobalSetting( 'typography.fluid' ); | ||
|
|
||
| if ( ! origin || ! slug ) { |
ramonjd
approved these changes
Oct 2, 2024
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
Tested quickly in playground. Thanks for catching this so quickly.
Contributor
Contributor
Author
|
I updated this PR as #65791 was merged. The following warning was raised, so I moved the location of The issue reported in #65711 has been resolved as before in this PR, and #65774 should not have reoccurred: d3f08e437dc371600e5ed42fc6dcc687.mp4 |
ciampo
approved these changes
Oct 2, 2024
ciampo
left a comment
ciampo
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀
As mentioned before, the real fix should be applied in Navigator. Once that's done, we'll be able to rework the code, removing the early returns (and using goTo only as a fail-safe for other use-cases)
|
Flaky tests detected in dd9380b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11142791584
|
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
* Fix: Shadow/Font size preset panel crashes the editor * Refactor logic Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…ess#65765)" This reverts commit f162973.
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Fix: Shadow/Font size preset panel crashes the editor * Refactor logic Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix for #65711
Related to #64777
What?
This PR fixes a critical error that occurs when returning to the previous screen from the shadow presets panel or the font presets panel.
This fix isn't ideal, but we need to prevent the issue from shipping in the upcoming Gutenberg 19.4.
Why?
I found that the problem was caused by #64777.
From this comment:
How?
Perform an early return to avoid a critical error when the parameter is undefined. One ideal future solution is suggested in this comment.
Testing Instructions
Screenshots or screencast
93efe80e1db33057473dc1044f3d0ccc.mp4