Blocks: Don't memoize 'hasContentRoleAttribute' selector#65617
Merged
Conversation
Mamaduka
added
[Feature] Blocks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Sep 24, 2024
tyxla
approved these changes
Sep 24, 2024
|
Size Change: -8 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Contributor
|
Why were we memoizing it then? |
Member
It was introduced in #43037 and I don't see a good reason to do it. Perhaps to avoid looping through all the block type attributes on every run, but I don't foresee a performance issue with that. |
Member
Author
Not sure. It was introduced in #43037, and there are no notes about memoization. @jorgefilipecosta might remember more context. |
jsnajdr
approved these changes
Sep 24, 2024
jsnajdr
left a comment
jsnajdr
left a comment
Member
There was a problem hiding this comment.
Why not, the memoization is not particularly valuable here. If nothing else, it simplifies the code. Originally the createSelector call was probably added out of habit, simply because most other selectors also use it. Nothing bad about it.
| } | ||
|
|
||
| return Object.entries( blockType.attributes ).some( | ||
| ( [ , { role, __experimentalRole } ] ) => { |
Member
There was a problem hiding this comment.
We can just use Object.values if we are not interested in the keys.
Contributor
Only because of the reasons @Mamaduka stated (i.e. if there was no value why was it added in the first place?).
Makes sense and is understandable. Thanks all 🚢 |
|
Flaky tests detected in 9a1273f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11016459521
|
|
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk. |
This was referenced Sep 25, 2024
Merged
noisysocks
pushed a commit
that referenced
this pull request
Sep 30, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
noisysocks
pushed a commit
that referenced
this pull request
Sep 30, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
noisysocks
added
Backported to WP Core
Member
|
Thank you for this change, yah memoization here does not make sense I think I included by mistake because the related selectors had it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #65484.
PR removes memoization for the private
hasContentRoleAttributeselector.Why?
The selector returns primitive boolean values; there should be no need to memorize. It's hard to anticipate performance improvements for similar optimizations without real data like CodeVitals.
Testing Instructions
CI checks should be green.