Skip to content

Try: Update block warnings. #64997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasmussen merged 1 commit into from
Sep 3, 2024
Merged

Try: Update block warnings. #64997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-editor/src/components/block-list/block-invalid-warning.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,12 @@ export default function BlockInvalidWarning( { clientId } ) {
onClick={ convert.toRecoveredBlock }
variant="primary"
>
{ __( 'Attempt Block Recovery' ) }
{ __( 'Attempt recovery' ) }
</Button>,
] }
secondaryActions={ secondaryActions }
>
{ __( 'This block contains unexpected or invalid content.' ) }
{ __( 'Block contains unexpected or invalid content.' ) }
</Warning>
{ compare && (
<Modal
Expand Down
11 changes: 2 additions & 9 deletions packages/block-editor/src/components/warning/content.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,14 @@
flex-wrap: wrap;
align-items: baseline;
width: 100%;
gap: $grid-unit-15;
}

.block-editor-warning__actions {
align-items: center;
display: flex;
margin-top: 1em;
gap: $grid-unit-10;
}

.block-editor-warning__action {
margin: 0 $grid-unit-10 0 0;
}
}

.block-editor-warning__secondary {
margin: auto 0 auto $grid-unit-10;
}

.components-popover.block-editor-warning__dropdown {
Expand Down
4 changes: 2 additions & 2 deletions packages/block-library/src/missing/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export default function MissingEdit( { attributes, clientId } ) {
messageHTML = sprintf(
/* translators: %s: block name */
__(
'Your site doesn’t include support for the "%s" block. You can leave this block intact, convert its content to a Custom HTML block, or remove it entirely.'
'Your site doesn’t include support for the "%s" block. You can leave it as-is, convert it to custom HTML, or remove it.'
),
originalName
);
Expand All @@ -84,7 +84,7 @@ export default function MissingEdit( { attributes, clientId } ) {
messageHTML = sprintf(
/* translators: %s: block name */
__(
'Your site doesn’t include support for the "%s" block. You can leave this block intact or remove it entirely.'
'Your site doesn’t include support for the "%s" block. You can leave it as-is or remove it.'
),
originalName
);
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/specs/editor/various/invalid-block.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ test.describe( 'Invalid blocks', () => {
await expect(
editor.canvas
.getByRole( 'document', { name: 'Block: Paragraph' } )
.getByRole( 'button', { name: 'Attempt Block Recovery' } )
.getByRole( 'button', { name: 'Attempt recovery' } )
).toBeVisible();

expect( hasAlert ).toBe( false );
Expand Down