Block Patterns List: do not use Composite store#64983
Merged
ciampo merged 1 commit intoSep 3, 2024
Merged
Conversation
ciampo
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Sep 2, 2024
tyxla
left a comment
tyxla
left a comment
Member
There was a problem hiding this comment.
Code looks good and testing worked as described (thanks for the thorough instructions BTW) 🚀
ciampo
deleted the
feat/stabilize-composite/block-patterns-list-no-composite-store
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Extracted from #64723
Refactor the block patterns list widget so that it doesn't use the
storefromuseCompositeStoreto function.Why?
See #63704 (comment)
How?
By controlling the
activeIdstate via props.Testing Instructions
There shouldn't be any noticeably different behaviors — make sure that the following happens both in
trunkand in this PR:Screenshots
Kapture.2024-09-02.at.17.57.03.mp4