Components: move displayName assignment to top-level files#64793
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] Developer Documentation
mirka
approved these changes
Aug 26, 2024
mirka
left a comment
mirka
left a comment
Member
There was a problem hiding this comment.
Thanks for the consistency cleanup!
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…#64793) * Update CONTRIBUTING guidelines * Update Composite component * Update DropdownMenuV2 component --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
As discussed in #64613 (comment), this PR tweaks how the
displayNameis assigned to each sub-component.Previously, each
displayNameassignment was performed in the sub-component files — this PR moves the assignments to the top-level file.Why?
Since assigning a
displayNameto sub-components is a consequence of how we're building and exporting our composite components, moving the assignment closer to where the exported object is built just makes sense.How?
Moved the assignments across files, updated the CONTRIBUTING guidelines accordingly.
Testing Instructions
This PR has no runtime changes
CompositeandDropdownMenuV2subcomponents are named as expected in React Dev Tools and Storybook code snippets