Style engine: update type for getCSSValueFromRawStyle#64528
Conversation
… By default, T is set to string. This allows the function to be flexible with the type of styleValue, but it defaults to handling strings.
ramonjd
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Update utils.ts - change type to StyleValue
ramonjd
force-pushed
the
fix/style-engine-function-css-value-typing
branch
from
b42393f to
44de688
Compare
|
Flaky tests detected in 44de688. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10399358112
|
2 participants
What?
Follow up to #64490
Use a generic type parameter
StyleValueto describe argument and return value ofgetCSSValueFromRawStyle().Props to @kevin940726
Why?
Avoid the use of
anyand describe better what the function expects.How?
By default,
StyleValueis set to string. This allows the function to be flexible with the type of styleValue, but it defaults to handling strings.getCSSValueFromRawStyle()takes one parameter,styleValue, which is of typeStyleValue = string. This means it can be any type, but the function is primarily designed to work with strings.getCSSValueFromRawStyle()returns a value of the same typeStyleValue. This ensures that its output type matches its input type.Testing Instructions
The CI should build, all tests should pass.