Block Bindings: Improve how the context needed by sources is extended in the editor#63513
Merged
SantosGuillamot merged 20 commits intoJul 24, 2024
Conversation
SantosGuillamot
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 kB (+0.17%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
64 tasks
SantosGuillamot
force-pushed
the
try/register-sources-from-the-server
branch
from
7df4050 to
0838beb
Compare
SantosGuillamot
requested review from
ajitbohra,
nerrad,
ntwb and
spacedmonkey
as code owners
SantosGuillamot
force-pushed
the
try/register-sources-from-the-server
branch
from
55929a0 to
50cfa09
Compare
SantosGuillamot
force-pushed
the
try/improve-how-bindings-context-is-extended-in-the-editor
branch
from
e91174b to
9fcf841
Compare
artemiomorales
approved these changes
Jul 23, 2024
artemiomorales
left a comment
artemiomorales
left a comment
Contributor
There was a problem hiding this comment.
Aside from the two descriptions for the tests below, this looks good to me 👍 I believe this is good to merge if those are addressed.
SantosGuillamot
deleted the
try/improve-how-bindings-context-is-extended-in-the-editor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Stealing the code from Ella in this other pull request.
This pull request uses the code from #63470 to reuse and merge the
usesContextdefined by the source in the server.There are a few things happening:
usesContextdefined by the source in the server registration.usesContextproperty to the client source registration to let sources extend that if needed.Why?
Block bindings shouldn't have to affect the block registration and the context can be accessed just in time.
Apart from that, it should reuse the server definition to avoid duplication in server and client registrations.
Testing Instructions
I added some automated tests to ensure everything works as expected: link.