Remove dotted border from grid dropzone#63162
Merged
Merged
Conversation
tellthemachines
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -20 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Member
|
Why do the cells change colour slightly when I change selection between the grid and the grid item? Or am I seeing things? Kapture.2024-07-05.at.15.16.24.mp4 |
Contributor
Author
When grid items are selected the dropzones appear, but when it's just the parent grid selected they don't. |
Contributor
|
Nice one. Thanks for following up. I'd love to also see a 2px rounded radius on the cells, if that's possible. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes regression introduced in #61025 as per this comment.
Removes dotted border from grid cell dropzones.
Testing Instructions
1.In Gutenberg > Experiments enable the Grid experiment;
2. Add a Grid block to a post or template and add some blocks inside it;
3. Switch the Grid to Manual mode in the block sidebar under "Layout";
4. Select one of the child blocks of the Grid;
5. Check that grid cells are highlighted with a solid line and not a dotted one.
Before:
After: