Merge #63002 into wp/6.6 - Site Editor: patterns and templates cannot be edited from sidebar mobile view#63055
Merged
oandregal merged 1 commit intoJul 2, 2024
Conversation
…ile view (#63002) * In mobile mode, check for canvas edit mode so the "Edit" callback redirect the browser to the block editor in edit mode * I suspect that the transition is causing intermittent crashing in Chrome in mobile viewports. Turning it off as it appears more stable in local testing. * Revert unintentional change Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: priethor <priethor@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org> Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org> Co-authored-by: mrfoxtalbot <mrfoxtalbot@git.wordpress.org>
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jul 2, 2024
|
Flaky tests detected in 2cee795. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9760391033
|
oandregal
approved these changes
Jul 2, 2024
oandregal
left a comment
oandregal
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix. I can repro the bug in 6.6 and this fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Merging #63002 into
wp/6.6#63002 addressed the following:
Note
This PR omits the changes added in #62705 if you were wondering why the code is different to #63002
Why?
There were merge conflicts, mainly due to #62705 not featuring in the
wp/6.6branch.Testing Instructions
Taken from #63002
782pxwide to trigger the mobile viewThis branch in action
2024-07-02.21.48.09.mp4