CustomSelectControl: Fix menuProps mutation#62149
Merged
Merged
Conversation
tyxla
added
[Type] Code Quality
Member
Author
|
I don't think this needs a CHANGELOG entry, but I'm happy to add one if convinced otherwise. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +12 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
mirka
approved these changes
May 30, 2024
mirka
left a comment
mirka
left a comment
Member
There was a problem hiding this comment.
I have an urge to rework this a bit more drastically, but given the practical motivation for this PR and the fact that we'll be entirely replacing this with the v2 Legacy implementation soon, I think this is perfectly sufficient 👍
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a mutation that we're performing in the
CustomSelectControlcomponent and updates to use a new object instead.Why?
In this particular case, I'm fixing it to resolve an ESLint error that was raised by the React Compiler ESLint plugin in #61788
How?
Using a new object instead of mutating the existing one.
Testing Instructions
Verify the v1
CustomSelectControlcomponent still works.Testing Instructions for Keyboard
None
Screenshots or screencast
None