Skip to content

Fix: React compiler error on button.#61958

Merged
jorgefilipecosta merged 1 commit into
trunkfrom
fix/react-compiler-error-on-button
May 29, 2024
Merged

Fix: React compiler error on button.#61958
jorgefilipecosta merged 1 commit into
trunkfrom
fix/react-compiler-error-on-button

Conversation

@jorgefilipecosta

Copy link
Copy Markdown
Member

Fixes a react compiler error on the button component.
Fixes the following error:

[2] /home/runner/work/gutenberg/gutenberg/packages/components/src/button/index.tsx
[2]   184:4  error  Mutating a value returned from a function whose return value should not be mutated  react-compiler/react-compiler
[2] 

Part of the work required to have React compiler on the codebase.
See #61788.

Testing Instructions

I staged my changes on #61788 and verified the error disappeared.

@jorgefilipecosta jorgefilipecosta added the [Type] Code Quality Issues or PRs that relate to code quality label May 24, 2024
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jorgefilipecosta jorgefilipecosta merged commit c4e00ff into trunk May 29, 2024
@jorgefilipecosta jorgefilipecosta deleted the fix/react-compiler-error-on-button branch May 29, 2024 18:24
@github-actions github-actions Bot added this to the Gutenberg 18.5 milestone May 29, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jun 4, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant