Data views: Always show Actions table header#61847
Merged
Merged
Conversation
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +35 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7b03534. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9186864700
|
t-hamano
reviewed
May 23, 2024
t-hamano
left a comment
t-hamano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR!
I didn't know that not being able to see table header text was an issue before. Various approaches were considered in #42555, but I think it's okay to ship this PR for now.
@jameskoster what do you think?
Contributor
Author
|
Thanks @t-hamano. The visibility of the ellipsis button is still a problem though. However it is now a broader issue, not limited to the data views. In #42555 (comment) I promised to create a specific issue about the ellipsis button but failed to do so. Will do it now. |
Contributor
Is it not adequate that numerous actions appear on row hover/focus? |
Contributor
Author
As a low vision user, I can't even visually identify the column. From a semantics perspective, I'm not sure I understand why this UI uses a table and then it hides one of the table headers, which are essential part of a table. Semantics and functionality should come first, befor any other considerations related to visual clutter or aesthetics. |
jameskoster
approved these changes
May 30, 2024
jameskoster
left a comment
jameskoster
left a comment
Contributor
There was a problem hiding this comment.
The thinking was that given the cells clearly contain actions, and that the header had no menu (like other headers in the table), that we could afford to visually hide it, in this case. If it's not the case, let's revert :)
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #61710 (comment)
Reverts #61710
What?
Makes the 'Actions' table header in the data views always visible.
Why?
Hiding table heders is less than ideal for the reasons explained in #61710 (comment)
Previously: #42505
How?
Reverts the changes from #61710
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast