Shadows: Unlock private components and hooks at the file level#61790
Merged
Conversation
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
requested review from
madhusudhand and
tyxla
and removed request for
ellatrix
|
Size Change: +46 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
May 20, 2024
tyxla
left a comment
tyxla
left a comment
Member
There was a problem hiding this comment.
Tests well and code looks good 👍
Member
|
Did you check this for the whole package? |
Member
Author
|
@ellatrix, I fixed the ones reported by the new linter plugins. It was a manual effort updating similar code, but at least now we have a linter for it. There are a couple more, but they are unrelated to the private APIs. |
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ress#61790) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A micro-optimization moves the private
Compositecomponent and hook unlocking outside the components, at the file level.Why?
Resolving an error reported by
eslint-plugin-react-compiler. See #61788.This is similar to #55809.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast