Hide the close button on the inserter for widgets editor#61510
Merged
Conversation
MaggieCabrera
requested review from
adamziel,
draganescu and
kevin940726
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
changed the title
MaggieCabrera
added
the
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Contributor
|
This is not the ideal way to fix it, as it hides the Reusing code does have a value but, in the Widgets screen, the inserter should not use an ARIA tabs interface in the first place. Will create a separate issue. Cc @youknowriad |
ajlende
added
the
[Feature] Widgets Screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The widget editor is showing the close button from #61421 when it doesn´t need it
Why?
It's a bug
How?
Updating the CSS that hides the tabs, we hide the whole header to also include the new button
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: