Fix close button position on inserter#61463
Closed
MaggieCabrera wants to merge 3 commits into
Closed
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @dean@fs276ed391.tkyc007.ap.nuro.jp. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
added
[Type] Bug
|
Size Change: +5 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2837a51. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8994963660
|
richtabor
requested changes
May 8, 2024
richtabor
left a comment
richtabor
left a comment
Member
There was a problem hiding this comment.
Works fine on desktop, but not mobile:
Contributor
Author
|
Closing in favor of a revert of #61426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The close button that we made visible in #61426 is moving unexpectedly into the second sidebar when we navigate to a category inside patterns for example
Why?
This is a bug, the button should stay in its place
How?
We make use of the width of the inserter sidebar component so it's always in the same spot
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: