Obviate mousetrap around Navigation Link popover#61050
Merged
Merged
Conversation
|
Size Change: +459 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
stokesman
changed the title
stokesman
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
added
the
[Feature] Link Editing
getdave
approved these changes
Apr 26, 2024
getdave
left a comment
getdave
left a comment
Contributor
There was a problem hiding this comment.
Thank you so much for the follow up here.
I tested and can confirm that the removal works perfect for both top and sub level menu items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the unnecessary mousetrap introduced in #57756 and refactors a bit to avoid the issue the mousetrap was working around.
Why?
To improve maintainability and with this we can probably consider #58825 resolved.
How?
onClosecallback and necessitating the mousetrap workaround.urlso the test had to be updated to customize the link for it to be saved.urlbecause it should only happen when the block is selected. It was previously being canceled by the effect to close the ui when the block was not selected. However, changing it to only show when selected wasn’t working for new links in submenus because they were not being selected. So this commit also selects the newly created link when transforming to a submenu.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast