Pullquote: Reduce specificity of padding rule to avoid conflicts with global styles#60649
Merged
Merged
Conversation
andrewserong
added
[Type] Bug
|
Size Change: -3 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Apr 11, 2024
tellthemachines
left a comment
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this! It's testing well for me 👍
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for fixing the issue so quickly! |
This was referenced Apr 12, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #60646
Reduce the specificity of the Pullquote block's default padding rules.
Why?
With global styles rules specificity being reduced as of #60106, the default padding rule for the Pullquote wins out over padding rules set at the block level in
theme.json. TT4 theme is a good example of a theme that provides its own padding values for this block.How?
Include the Pullquote block's padding rules in the lower specificity
:where()rule so that the global styles rules will win out. I believe the objective with this particular padding rule was for anything else to override it (i.e. theme styles or global styles), so hopefully this should be a fairly safe reduction. I've smoke tested with TT4, Twenty Twenty and a couple of other themes.Testing Instructions
trunk, the issue in Pullquote: Theme defined padding is overridden by default #60646 appears — there is too much padding on the block, and the global styles rules do not win outScreenshots or screencast