Block Bindings: set allow blocks list from source handler#60335
Closed
retrofox wants to merge 9 commits into
Closed
Block Bindings: set allow blocks list from source handler#60335retrofox wants to merge 9 commits into
retrofox wants to merge 9 commits into
Conversation
|
Size Change: +157 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
retrofox
force-pushed
the
update/bindings-source-handler-define-blocks-to-bind
branch
from
1cec195 to
3278a35
Compare
gziolo
added
the
[Type] Technical Prototype
Member
|
There is now an issue open by @zaguiini that describes how the block types and their attributes will get annotated on the block registration level: In the same area, @fabiankaegy described how we could allow using block bindings with dynamic blocks: @retrofox, do you plan to continue working on this PR? |
gziolo
added
the
[Status] Stale
Contributor
Author
Yes, I do. I'm not sure whether it's doable in the short time, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR allows defining the block attributes that can be bound from the source handler instead of a hardcoded list.
Why?
It allows for binding an attribute of a custom block, for instance.
How?
For this purpose, the PR introduces the
settingsproperty to the source handler, which makes it possible to define the block attributes allowed to bind. For instance, for the core/post-meta source handler:Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast