Enable PHP change detection even from forked repositories#59780
Closed
t-hamano wants to merge 1 commit into
Closed
Enable PHP change detection even from forked repositories#59780t-hamano wants to merge 1 commit into
t-hamano wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
This workflow has been removed as of #62609 and should no longer cause the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59441
What?
This PR will detect changes in PHP files and leave comments even when a PR is submitted from a forked repository.
Why?
GitHub Actions shows an error like below.
I think this issue is similar to #52981. If the PR is from a forked repository, I would expect GitHub Actions to fail because contributors don't have write permission.
How?
I changed the trigger from
pull_requesttopull_request_target. This GitHub Actions uses peter-evans/create-or-update-comment, which is also mentioned in that repository's README as follows:Testing Instructions
I believe this PR makes sense, but I don't know how to test that this PR is correct 😅
Testing Instructions for Keyboard
Screenshots or screencast