Site Editor: Fix selected featured image when opening media library#59769
Merged
Conversation
ntsekouras
added
[Type] Bug
|
Size Change: +15 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Mar 12, 2024
| // not for site editor. | ||
| wp.media.view.settings.post = { | ||
| ...wp.media.view.settings.post, | ||
| id: postId, |
Contributor
There was a problem hiding this comment.
postId is a new prop right? I'm thinking that maybe in some flows, the postId is not passed properly to the component and in which case, we may want to keep the globally applied one no?
Contributor
There was a problem hiding this comment.
Also should we check other <MediaUpload usage in the site editor to check whether we might be missing the postId. For instance uploading regular images while editing a post in the post editor marks the image as attached to the post, but it might not be the case in the site editor. (I'm assuming this latest part is not specific to 6.5 though)
Contributor
Author
There was a problem hiding this comment.
Makes sense and the complexity in those flows in core is big. I removed the postId for now, since the changes are specific to the featured image flow(unstableFeaturedImageFlow) and the featured image prop is enough for proper selection.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Mar 12, 2024
| // not for site editor. | ||
| wp.media.view.settings.post = { | ||
| ...wp.media.view.settings.post, | ||
| featuredImageId: featuredImageId || -1, |
Contributor
There was a problem hiding this comment.
Now the question, what happens when you open the media library for featured image then you open it for a regular image. do we need to unset this global property? What will be its impact otherwise?
Contributor
Author
There was a problem hiding this comment.
From what I understood from the code this prop is used for the featured image flow and would not affect anything else. It seems the flow for featured image in wp.media fine tunes some things under the hood, like single selection, confirm button to have set featured image, etc..
youknowriad
approved these changes
Mar 12, 2024
Contributor
|
This is a regression introduced during the 6.5 cycle, so let's include in RC2. |
getdave
pushed a commit
that referenced
this pull request
Mar 12, 2024
…59769) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
getdave
added
Backported to WP Core
Contributor
|
I just manually cherry-picked this PR to the pick/wp-65-rc-2 branch to get it included in the next release |
getdave
pushed a commit
that referenced
this pull request
Mar 12, 2024
…59769) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…ordPress#59769) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #59768
With our unification efforts for site and post editor the featured image panel is reused now in both editors. The featured image panel in site editor results in showing an extra empty thumbnail when opening the media library.
It turns out it all starts with
wp_enqueue_mediawhere in post editor we pass the proper post id, which is responsible for many many things, including setting options for the proper selection too. I don't think that would be the way for site editor as the script loads once and in site editor we update thepostIdwithout reloading.In my approach I update the needed settings when we open the media library modal client side.
Testing Instructions
Before
Screen.Recording.2024-03-12.at.9.46.41.AM.mov
After
after.mov