Font Library: Refactors the upload handler in order to check if files being uploaded are valid font files.#59648
Merged
Merged
Conversation
added 2 commits
March 6, 2024 17:04
Fixes: #59578 Refactors the upload handler in order to check if files being uploaded are valid font files.
vcanales
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
vcanales
changed the title
|
Size Change: +355 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
peterwilsoncc
approved these changes
Mar 7, 2024
peterwilsoncc
left a comment
peterwilsoncc
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me and test well.
I've got a few nitpicks in to match the documentation standards and add a return type to the docblock.
Pre-approving as the code is LGTM.
t-hamano
reviewed
Mar 7, 2024
carolinan
reviewed
Mar 7, 2024
Contributor
|
Not a code review. 
|
…odal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
…odal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
…odal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
…odal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
…odal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
…odal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
…odal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
…odal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
vcanales
commented
Mar 7, 2024
matiasbenedetto
approved these changes
Mar 7, 2024
Contributor
There was a problem hiding this comment.
This works as advertised: invalid font files raise an error notice, and valid font files continue to upload as expected.
Because of that, I approved the PR. Still, I think we could simplify the code a little by doing this: https://github.com/WordPress/gutenberg/pull/59648/files#r1516698107
LGTM
getdave
reviewed
Mar 11, 2024
getdave
reviewed
Mar 11, 2024
Contributor
|
I broken the linting. I'll fix that shortly. |
Contributor
|
Proposing for inclusion in WP 6.5 during RC period because this is a bug in the critical upload path for the Font Libray feature. It seems to have been identified during the RC testing phase. |
getdave
added a commit
that referenced
this pull request
Mar 11, 2024
… being uploaded are valid font files. (#59648) * Font Library: check if file upload is valid font Fixes: #59578 Refactors the upload handler in order to check if files being uploaded are valid font files. * make sure error message is relevant * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * error message syntax * use WordPress yoda condition * Respect string freeze * Fix lint --------- Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> Co-authored-by: Dave Smith <getdavemail@gmail.com>
getdave
added
Backported to WP Core
Contributor
|
I just manually cherry-picked this PR to the pick/wp-65-rc-2 branch to get it included in the next release |
getdave
added a commit
that referenced
this pull request
Mar 12, 2024
… being uploaded are valid font files. (#59648) * Font Library: check if file upload is valid font Fixes: #59578 Refactors the upload handler in order to check if files being uploaded are valid font files. * make sure error message is relevant * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * error message syntax * use WordPress yoda condition * Respect string freeze * Fix lint --------- Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> Co-authored-by: Dave Smith <getdavemail@gmail.com>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
… being uploaded are valid font files. (WordPress#59648) * Font Library: check if file upload is valid font Fixes: WordPress#59578 Refactors the upload handler in order to check if files being uploaded are valid font files. * make sure error message is relevant * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> * error message syntax * use WordPress yoda condition * Respect string freeze * Fix lint --------- Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> Co-authored-by: Dave Smith <getdavemail@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Refactors the upload handler in order to check if files being uploaded are valid font files.
Why?
Fixes: #59578
Uploading invalid font files would cause the uploader to crash due to lack of error handling.
Testing Instructions