Block Bindings: Fix console error when selecting a bound block#59598
Merged
SantosGuillamot merged 1 commit intoMar 5, 2024
Conversation
SantosGuillamot
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Mar 5, 2024
|
Size Change: -14 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Contributor
|
This PR fixes an unwanted error in dev tools output that could be confusing for developers working with the new Block Bindings feature that is shipping with WP 6.5. The scope of the change is very limited and for these reasons I feel it is suitable for inclusion in WP 6.5 during the RC phase. |
getdave
pushed a commit
that referenced
this pull request
Mar 11, 2024
Contributor
|
I just cherry-picked this PR to the pick/wp-65-rc-2 branch to get it included in the next release: 3c42446 |
getdave
added
Backported to WP Core
getdave
pushed a commit
that referenced
this pull request
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This pull request introduced a bug that throws a console error when a user select a block that is bound.
In this pull request, I'm fixing it but using the appropriate property.
Why?
We shouldn't have errors.
How?
Using the proper property in the React icon.
Testing Instructions