Skip to content

Cover Block: Restore overflow: clip rule to allow border radius again #59388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 2 commits into from
Feb 27, 2024
Merged

Cover Block: Restore overflow: clip rule to allow border radius again #59388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1175f6
Cover Block: Restore overflow: clip rule to allow border radius again
andrewserong Feb 27, 2024
9442803
Fully restore to prior to aspect ratio PR
andrewserong Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/block-library/src/cover/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@
align-items: center;
padding: 1em;
// Prevent the `wp-block-cover__background` span from overflowing the container when border-radius is applied.
// `overflow: hidden` is provided as a fallback for browsers that don't support `overflow: clip`.
overflow: hidden;
// Use clip instead of overflow: hidden so that sticky position works on child elements.
// Use overflow-x instead of overflow so that aspect-ratio allows content to expand the area of the cover block.
overflow-x: clip;
overflow: clip;
// This block has customizable padding, border-box makes that more predictable.
box-sizing: border-box;
// Keep the flex layout direction to the physical direction (LTR) in RTL languages.
Expand Down