Block Hooks API: Update Navigation block feature gate#58388
Merged
tjcafferkey merged 2 commits intoJan 29, 2024
Merged
Conversation
ockham
reviewed
Jan 29, 2024
ockham
reviewed
Jan 29, 2024
Contributor
|
@c4rl0sbr4v0 We'd like to include this in GB 17.6. Should we cherry-pick to the (Edit: No need for a separate RC, IMO.) |
|
Flaky tests detected in d62993a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7698726773
|
Contributor
|
Hi @ockham With the label is enough, I will do a RC3 tomorrow (for other PRs 😅 ), not this one. |
cbravobernal
pushed a commit
that referenced
this pull request
Jan 30, 2024
Contributor
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 8a7d26b |
3 tasks
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the feature gate for usage of the Block Hooks API to insert inner blocks into the core Navigation block.
Why?
We were previously checking for
get_hooked_blocksto gate this feature against WordPress 6.3 and below, however this feature also depends upon the metadataignoredHookedBlocksfunctionality to work correctly which isn't present within WordPress 6.4, resulting in a bug surfacing itself.How?
I've updated the feature gate to check for the function responsible for the
ignoredHookedBlockslogic that we need, which prevents this running on WP 6.4 until compat code is ported over.Testing Instructions
On WP 6.4
On WP 6.5 Beta