Block Hooks API: Remove $post check from Navigation hooked blocks meta fn#58379
Merged
youknowriad merged 1 commit intoJan 29, 2024
Conversation
3 tasks
youknowriad
added
the
Backport to Gutenberg RC
ockham
approved these changes
Jan 29, 2024
ockham
left a comment
ockham
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for the fix.
Contributor
As discussed on Slack, this is what convinced me that we should be fine removing the extra check from the filter. Core even goes out of its way to find out and specify what the error is. Only after that does it call |
Contributor
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: f217c68 |
cbravobernal
removed
the
Backport to Gutenberg RC
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the check on
$post->IDand silent return inblock_core_navigation_update_ignore_hooked_blocks_metasince Core guarantees its existence.Why?
This part of the code was picked up during the package updates for 6.5 here. Core pretty much guarantees this data will be available within the callback as seen here and here.
How?
This removes the code which executes a silent return on an unnecessary check.
Testing Instructions
If required, regression testing steps on this feature can be found on this PR #57754