Skip to content

Block Hooks API: Update doc block for block_core_navigation_insert_hooked_blocks#58378

Merged
youknowriad merged 5 commits into
WordPress:trunkfrom
tjcafferkey:update/core-navigation-block-hooks-doc-block
Jan 30, 2024
Merged

Block Hooks API: Update doc block for block_core_navigation_insert_hooked_blocks#58378
youknowriad merged 5 commits into
WordPress:trunkfrom
tjcafferkey:update/core-navigation-block-hooks-doc-block

Conversation

@tjcafferkey

Copy link
Copy Markdown
Contributor

What?

Updating doc block for block_core_navigation_insert_hooked_blocks used in the core Navigation block

Why?

It was caught and highlighted during the package updates for 6.5 here and requires a PR in GB to fix WordPress/wordpress-develop#5922 (comment)

How?

It's implementing suggested changes which are directly copied from Gutenberg.

@tjcafferkey tjcafferkey changed the title Update doc block for block_core_navigation_insert_hooked_blocks Block Hooks API: Update doc block for block_core_navigation_insert_hooked_blocks Jan 29, 2024
@youknowriad youknowriad requested a review from costdev January 29, 2024 13:05
@youknowriad youknowriad added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jan 29, 2024
Comment thread packages/block-library/src/navigation/index.php Outdated
@ockham ockham added the [Block] Navigation Affects the Navigation Block label Jan 29, 2024
@tjcafferkey tjcafferkey requested a review from ockham January 29, 2024 15:42
Comment thread packages/block-library/src/navigation/index.php Outdated
Co-authored-by: Bernie Reiter <96308+ockham@users.noreply.github.com>
@tjcafferkey tjcafferkey requested a review from ockham January 29, 2024 16:00

@ockham ockham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ockham ockham added this to the Gutenberg 17.6 milestone Jan 29, 2024
Comment thread packages/block-library/src/navigation/index.php Outdated
@youknowriad youknowriad enabled auto-merge (squash) January 30, 2024 08:39
@youknowriad youknowriad merged commit a2f6512 into WordPress:trunk Jan 30, 2024
cbravobernal pushed a commit that referenced this pull request Jan 30, 2024
…oked_blocks (#58378)

Co-authored-by: Bernie Reiter <96308+ockham@users.noreply.github.com>
@cbravobernal

Copy link
Copy Markdown
Contributor

I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: ba74bfc

@cbravobernal cbravobernal removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jan 30, 2024
youknowriad pushed a commit that referenced this pull request Jan 31, 2024
…oked_blocks (#58378)

Co-authored-by: Bernie Reiter <96308+ockham@users.noreply.github.com>
@bph bph added the [Type] Developer Documentation Documentation for developers label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Navigation Affects the Navigation Block [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants