Fix site editor layout regressions#58077
Merged
Merged
Conversation
jameskoster
added
the
[Type] Bug
|
Size Change: -16 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 72af9ae64ef7dccfc4126a1ecdee8c1c16afa053. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7614231561
|
t-hamano
reviewed
Jan 22, 2024
Contributor
There was a problem hiding this comment.
This PR makes it appear to be working as expected. As an improvement idea, is it possible to delete duplicate styles between .edit-site-layout__area and .edit-site-page?
The approach I think is to apply to each element only the CSS expected for its role. From what I've tested, the following changes in this PR should also work:
.edit-site-layout__area {
flex-grow: 1;
margin: 0;
overflow: hidden;
@include break-medium() {
border-radius: 8px;
margin: $canvas-padding $canvas-padding $canvas-padding 0;
}
}.edit-site-page {
color: $gray-800;
background: $white;
height: 100%;
}I also found that disabling "New Admin View" created unnecessary margin on the Pattern page. This is because border-radius and margin are applied to .edit-site-layout__area, but these two styles are required for this PR for now. In the old Patterns pages, we might need to override this style or remove the .edit-site-layout__area element.
Contributor
Author
Absolutely. I'll push those changes shortly. I noticed the patterns issue too and left a note on the issue. I think that's one to address in a separate PR. |
t-hamano
approved these changes
Jan 23, 2024
t-hamano
left a comment
t-hamano
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 The unit test failure seems to be fixed in the latest trunk. So if you merge the latest trunk into this PR, the test should pass.
ntsekouras
force-pushed
the
fix/site-editor-layout
branch
from
72af9ae to
af3746f
Compare
Contributor
|
@jameskoster @ntsekouras Can we merge this PR? From what I've tested, it seems perfectly fine. |
Contributor
Author
|
Let's merge. I'll update the original issue to ensure all the other problems don't get lost. Edit: I saw you already updated the issue, thanks :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some of the regressions introduced in #57938, as noted in #58044. Specifically:
Before
After